Repository navigation
fix(ios): keep Debug startup order for expo-dev-launcher under UIScene - #39
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Debug, expo-dev-launcher's app-delegate subscriber runs during
didFinishLaunchingand callsfatalErrorwhen there's no window yet. Under the UIScene lifecycle from #38, the window is only created when the scene connects, so every Debug build crashed at launch.Debug now creates the window and starts React Native during launch, as before #38;
SceneDelegateattaches that window to the scene. Release is unchanged and still starts React Native from the scene. This affects development builds only; 1.3.6 (20) is a Release build.Verified: the Debug build launches on the iOS 27 simulator, with no scene-lifecycle or keyWindow failure.