Repository navigation
Allow CRLF line endings in release workflow whitespace checks - #64840
Merged
Jake Bailey (jakebailey) merged 2 commits intoOct 16, 2026
Merged
Jake Bailey (jakebailey) merged 2 commits into
Jake Bailey (jakebailey) merged 2 commits into
Conversation
Herebyfile.mjs uses CRLF line endings, which a fresh runner's default whitespace policy rejects when the release version is changed. Local Git settings can hide this failure even when validation succeeds. Apply the repository's CRLF-aware whitespace policy explicitly in the release workflows while retaining checks for actual trailing spaces.
Release automation already limits changes to the release configuration, and validation handles formatting. An additional whitespace check is redundant and rejects the CRLF line endings used by Herebyfile.mjs. Rely on the existing file allowlists and clean-tree checks, consistent with CI, instead of maintaining a separate whitespace policy.
Jake Bailey (jakebailey)
requested review from
Daniel Rosenwasser (DanielRosenwasser)
and
a balanced review from Copilot
October 16, 2026 03:21
typescript-automation
Bot
added
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The three targeted removals address CRLF-related failures without altering the remaining workflow safeguards.
0 open findings
What changed in this PR
Removes git diff --check from three release-related workflows to avoid failures caused by CRLF line endings.
Changes:
- Removes whitespace checks while leaving worktree and expected-file safeguards unchanged.
| File | Description |
|---|---|
.github/workflows/sync-branch.yaml |
Removes whitespace checking before clean-merge verification. |
.github/workflows/set-version.yaml |
Removes whitespace checking before changed-file validation. |
.github/workflows/new-release-branch.yaml |
Removes whitespace checking before expected-file validation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Daniel Rosenwasser (DanielRosenwasser)
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fail because we have CRLFs. Oops.