Repository navigation
Ensure pathsBasePath is correctly forwarded from the API - #64843
Open
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
Open
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
Titian Cernicova-Dragomir (dragomirtitian) wants to merge 1 commit into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Copilot started reviewing on behalf of
Titian Cernicova-Dragomir (dragomirtitian)
October 16, 2026 09:35
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses the reported regression with targeted coverage and no identified blocking issues.
0 open findings
What changed in this PR
Fixes #64842 by preserving pathsBasePath when parsed compiler options pass through the API, keeping path mappings relative to the configuration directory.
Changes:
- Recognizes
pathsBasePathas a directory-valued option. - Adds unit and API regression tests for configuration-relative resolution.
| File | Description |
|---|---|
tsc/internal/tsoptions/rawcompileroptions.go |
Preserves and normalizes pathsBasePath. |
tsc/internal/tsoptions/rawcompileroptions_test.go |
Tests directory normalization. |
tsc/internal/api/session_createprogram_test.go |
Tests resolution after an API options round-trip with a different working directory. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64842