Repository navigation
fix: declare the public exports of the msgraph package - #1594
Open
Max Azatian (HardMax71) wants to merge 1 commit into
Open
Max Azatian (HardMax71) wants to merge 1 commit into
Max Azatian (HardMax71) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
msgraph/__init__.pyimportsGraphServiceClientandGraphRequestAdapterbut has no__all__(L5-L6). The package shipspy.typed, so mypy checks it, and--strictturns on--no-implicit-reexport. The import from the docs snippets then fails:Module "msgraph" does not explicitly export attribute "GraphServiceClient" [attr-defined].This adds
__all__withGraphRequestAdapter,GraphServiceClientandVERSION. A star import now gives exactly these three names. Before, it also picked up the submodulesgenerated,graph_request_adapterandgraph_service_client.Validation: with msgraph-sdk 1.64.0,
mypy --strictonfrom msgraph import GraphRequestAdapter, GraphServiceClientreports twoattr-definederrors, and with this change it passes.pylint msgraph/__init__.py --disable=W --rcfile=.pylintrcrates it 10.00/10.