Repository navigation
Conversation
Author
|
Closing this to keep my open PRs focused, since it hasn't gotten traction. Thanks for maintaining the project. Happy to reopen if it's still useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
App.connect()callssetupSizeChangedNotifications()but discards its cleanup function. Closing either side of the transport leaves the automatic resize observer subscribed; reconnecting the same App creates another subscription.Change
Retain the automatic cleanup and invoke it from the SDK's protected transport-close hook. Clear the reference first so it runs once, and delegate to the base hook in
finallyto preserve protocol teardown and the user'sonclosecallback.This is separate from #728's portal measurement and pending-animation-frame cleanup: this patch makes the connection invoke cleanup, without changing the implementation of manual resize setup. An already queued animation frame can still run after disconnect.
Validation
npm test440 passed, 2 skipped, 0 failed.npm run build, scoped Prettier formatting andgit diff --checkpass.AI assistance: implemented and independently reviewed with OpenAI Codex.