Skip to content

Ignore empty members of the Accept header #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dominikklein wants to merge 1 commit into from
+18 −2
Closed

Ignore empty members of the Accept header #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/mcp/server/transports/streamable_http_transport.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1884,8 +1884,9 @@ def validate_accept_header(request, required_types)
end

def parse_accept_header(header)
header.split(",").map do |part|
part.split(";").first.strip.downcase
header.split(",").filter_map do |part|
media_type = part.split(";").first.to_s.strip.downcase
media_type unless media_type.empty?
end
end

Expand Down
15 changes: 15 additions & 0 deletions test/mcp/server/transports/streamable_http_transport_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,6 +1756,21 @@ def string
assert_equal 200, response[0]
end

test "POST request with empty members in the Accept header succeeds" do
request = create_rack_request(
"POST",
"/",
{
"CONTENT_TYPE" => "application/json",
"HTTP_ACCEPT" => ", application/json,, text/event-stream",
},
{ jsonrpc: "2.0", method: "initialize", id: "123", params: initialize_params }.to_json,
)

response = @transport.handle_request(request)
assert_equal 200, response[0]
end

test "POST request with Accept: */* succeeds" do
request = create_rack_request_without_accept(
"POST",
Expand Down