Repository navigation
fix(http): align Node and Bun timeouts and response cleanup - #269
Merged
Merged
Conversation
- Preserve native fetch in both runtimes without upgrading Bun - Apply --timeout to request deadlines and stream idle protection - Abort underlying requests on cancellation and release unused Sandbox response bodies - Add regression tests for Node, Bun, and compiled binaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--timeoutconsistently at the application layer: JSON requests retain a total deadline; raw/streaming responses use a header deadline followed by a body idle window. Pause idle accounting during consumer processing and backpressure.The lifecycle handling follows the request-owned controller cleanup pattern used by Qwen Code RestSseTransport.
Validation
pnpm test --maxWorkers=4: 2,943 passed, 194 skipped.pnpm -r --filter './packages/*' build: passed.pnpm exec vp check: 0 errors and 3 existing warnings in unchanged files.Validation boundaries and known observations
SIGKILLevents were observed when launching newly compiled macOS binaries. A deploymentSIGINTtest also triggered its watchdog under default concurrency. Three independent review reruns passed all 246 test executions without reproducing either event in those runs. Their root causes remain undetermined; this PR does not assume an environmental cause or claim to resolve these observations.