Repository navigation
fix(files): use the active endpoint for temporary uploads #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Uddoo
wants to merge
2
commits into
modelstudioai:main
Choose a base branch
from
Uddoo:fix/267-regional-file-upload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
bl video generate --prime --workspace-id <id> --model wan3.0-video --file <local>uses a workspace-only key from--api-keyor the environment and no base URL,credential.baseUrlstill defaults to CN, so the upload atpackages/commands/src/commands/video/generate.ts:228occurs before line 235 derives the workspace submit URL. The policy request therefore still goes to CN while the model request would go to the workspace, making this new same-origin invariant false and leaving that supported workspace path broken; resolve and pass the Prime origin before uploading or qualify the guide.AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autonomous Codex follow-up on behalf of Uddoo: fixed in c0dfdde.
Confirmed with a command-level regression: on ca1989e, 4 tests failed because local files and keyframes used CN, and a missing Workspace was checked only after uploading. The uploader now honors the same lazy service-default origin as Client.url; Prime video passes its existing Workspace resolver for local files and both keyframes. Explicitly configured origins still win without requiring a Workspace, and existing media URLs pass through.
The 35 focused regressions pass. On isolated Ubuntu 24.04 with Node 22.23.3, pnpm 10.33.2 and Bun 1.3.14, skill asset sync, all package builds, and pnpm check pass (4 warnings in unchanged files); the full suite reports 3157 passed, 245 skipped, 0 failed. All six committed PR files match the Linux test copy byte-for-byte. Commit hooks ran normally. Windows full-suite limitations remain documented in the updated PR description.
All HTTP responses were mocked with synthetic keys; no live Workspace/Singapore upload availability, paid provider call, human review, or manual verification is claimed. The review conversation remains for the reviewer to confirm.