Skip to content

benchmark: fix hideStackFrames error benchmarks - #66723

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix-hidestackframes-error-benchmarks
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:fix-hidestackframes-error-benchmarks

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

benchmark: fix hideStackFrames error benchmarks

The benchmarks compared type against 'hide-stackframe' while the configured value is 'hide-stackframes', so both variants always ran the plain function. They also used HideStackFrameError, which does not exist; the property is HideStackFramesError.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Oct 14, 2026
@RafaelGSS RafaelGSS added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 14, 2026
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue PRs queued for automated landing through the Commit Queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants