Repository navigation
modules: implement deferred import for dynamic modules - #66727
Open
MayaLekova wants to merge 2 commits into
Open
MayaLekova wants to merge 2 commits into
MayaLekova wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
MayaLekova
force-pushed
the
import-defer-06-dynamic-imports
branch
from
October 14, 2026 13:51
2d077ed to
f8ef554
Compare
This PR adds support for deferring the import of modules in additional cases, such as importing a dynamic module. It also adds a test for this case. Refs: https://github.com/tc39/proposal-defer-import-eval Signed-off-by: Maya Lekova maya@igalia.com
MayaLekova
force-pushed
the
import-defer-06-dynamic-imports
branch
from
October 15, 2026 13:08
f8ef554 to
503ed1f
Compare
Contributor
Author
|
I tried fixing the @joyeecheung just FYI, I'll keep trying to fix it. |
joyeecheung
reviewed
Oct 15, 2026
| "});" | ||
| "await m.link(() => 0);" | ||
| "await m.evaluate();" | ||
| "await m.evaluate(-1, false, 3);" |
Member
There was a problem hiding this comment.
This is the public API for the vm API, which is not used by the built-in loader at all, and it's not the same as the module wrap's evaluate, which is internal and used by both. There's no need to touch this.
Member
|
Can you drop the amaro update commit? I don't think that's supposed to be in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modules: implement deferred import for dynamic modules
This PR adds support for deferring the import of modules in additional
cases, such as importing a dynamic module. It also adds a test for
this case.
Refs: https://github.com/tc39/proposal-defer-import-eval
Signed-off-by: Maya Lekova maya@igalia.com