Skip to content

permission: reject wildcard references when dropping env - #66773

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:reject-wildcard-references-when-dropping-env
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:reject-wildcard-references-when-dropping-env

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

cc: @jasnell @mcollina I guess that's the safest approach for env dropping wdyt?

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. labels Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (782a3ac) to head (f001daa).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #66773    +/-   ##
========================================
  Coverage   90.47%   90.48%            
========================================
  Files         791      797     +6     
  Lines      277225   277603   +378     
  Branches    53313    53329    +16     
========================================
+ Hits       250829   251198   +369     
+ Misses      16801    16799     -2     
- Partials     9595     9606    +11     
Files with missing lines Coverage Δ
src/permission/permission.cc 75.00% <100.00%> (+0.51%) ⬆️

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants