Repository navigation
test: skip openssl config test under BoringSSL - #66780
Merged
Merged
Conversation
Signed-off-by: David Babenko-Sanders <dsanders11@ucsbalum.com>
nodejs-github-bot
added
needs-ci
panva
approved these changes
Oct 16, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66780 +/- ##
==========================================
- Coverage 90.49% 90.49% -0.01%
==========================================
Files 797 797
Lines 277598 277598
Branches 53336 53330 -6
==========================================
- Hits 251220 251200 -20
- Misses 16790 16794 +4
- Partials 9588 9604 +16 🚀 New features to boost your workflow:
|
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
panva
added
the
commit-queue
richardlau
approved these changes
Oct 16, 2026
lpinca
approved these changes
Oct 16, 2026
Collaborator
|
Landed in 4737802 |
nodejs-github-bot
removed
the
commit-queue
dsanders11
pushed a commit
to electron/electron
that referenced
this pull request
Oct 18, 2026
Backports nodejs/node@4737802 (nodejs/node#66780) so parallel/test-openssl-unreadable-config skips under BoringSSL, which replaces the skip that fix_crypto_tests_to_run_with_bssl.patch carried. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vei8NnyvwjoY6bXEH7nKnR
dsanders11
pushed a commit
to electron/electron
that referenced
this pull request
Oct 18, 2026
…ackport Drop the custom fix_crypto_tests_to_run_with_bssl.patch and backport nodejs/node@4737802 (nodejs/node#66780), which skips test-openssl-unreadable-config under BoringSSL. The patch's other hunk, an ML-DSA test skip, is no longer needed since Node.js v24.22.0's test already accounts for BoringSSL. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vei8NnyvwjoY6bXEH7nKnR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while trying to drop a patch in downstream Electron in electron/electron#55043.