Skip to content

[v26.x] Revert "module: synchronously load most ES modules" - #66786

Open
aduh95 wants to merge 1 commit into
nodejs:v26.x-stagingfrom
aduh95:revert-62530
Open

aduh95 wants to merge 1 commit into
nodejs:v26.x-stagingfrom
aduh95:revert-62530

Conversation

@aduh95

@aduh95 aduh95 commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

This reverts:

There's a fix in #66770, but given the timing we cannot pick it before it's included in an Alpha or Current version first, and with LTS transition in less than two weeks it we cannot make a 26.x release. To allow the ecosystem to adopt the upcoming security release, we need to revert for now, it can be re-landed along with the fix in a regular LTS release later.

Refs: #66767
Refs: #62530

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels Oct 16, 2026
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.76%. Comparing base (ca26282) to head (539bbec).
⚠️ Report is 1255 commits behind head on v26.x-staging.

Additional details and impacted files
@@                Coverage Diff                @@
##           v26.x-staging   #66786      +/-   ##
=================================================
+ Coverage          90.24%   90.76%   +0.51%     
=================================================
  Files                729      775      +46     
  Lines             242760   273191   +30431     
  Branches           46044    52447    +6403     
=================================================
+ Hits              219073   247950   +28877     
- Misses             15133    16123     +990     
- Partials            8554     9118     +564     
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 99.80% <100.00%> (+0.09%) ⬆️
lib/internal/modules/esm/module_job.js 99.27% <100.00%> (ø)
lib/internal/modules/run_main.js 100.00% <ø> (+2.35%) ⬆️

... and 410 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants