Skip to content

build: sync rustc version warning - #66794

Open
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:codex/align-rustc-minimum
Open

inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:codex/align-rustc-minimum

Conversation

@inoway46

@inoway46 inoway46 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Raise the rustc warning threshold to 1.88 to match BUILDING.md and deps/crates/Cargo.toml.

rust-version = "1.88"

Refs: #65912 (comment)

Raise the rustc warning threshold to 1.88 to match BUILDING.md and
deps/crates/Cargo.toml. Keep the cargo threshold at 1.86.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 16, 2026
@inoway46
inoway46 marked this pull request as ready for review October 16, 2026 15:51
@legendecas legendecas added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 16, 2026
@legendecas

Copy link
Copy Markdown
Member

Mirroring dont-land labels as #65742.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants