Repository navigation
Conversation
Track the test that owns the current async context with an AsyncLocalStorage instead of a createHook() init/destroy map. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
mcollina
requested review from
MoLow and
atlowChemi
and removed request for
MoLow
October 16, 2026 16:01
mcollina
marked this pull request as ready for review
October 16, 2026 16:01
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66795 +/- ##
==========================================
- Coverage 90.50% 90.48% -0.02%
==========================================
Files 797 797
Lines 277652 277656 +4
Branches 53345 53337 -8
==========================================
- Hits 251282 251247 -35
- Misses 16758 16799 +41
+ Partials 9612 9610 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track the test that owns the current async context with an AsyncLocalStorage instead of a
createHook()init/destroy map, sonode:testno longer installs async hooks (including promise hooks) for every run.Test#runInAsyncScope()enters the test's context directly rather than wrappingAsyncResource#runInAsyncScope(), to avoid adding frames to user stack traces. The snapshot changes drop one<node-internal-frames>line, since that frame now lives in the test runner and is filtered out.Refs: #61030
AI generated, reviewed by me