Repository navigation
Conversation
CPython reports sys.flags.debug as 0 unless -d is given. GraalPy was setting it from the inverse of PythonOptimizeFlag, so the default value was 1. Fixes oracle#1213 Signed-off-by: hippi345 <13539685+hippi345@users.noreply.github.com>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CPython keeps
sys.flags.debugat0unless-dis given. GraalPy was initializing that field from!PythonOptimizeFlag, so the default value was1.This change sets
sys.flags.debugto0and adds a GraalPy unittest that asserts the default.Fixes #1213
Test plan
SysFlagsTests.test_debug_is_zero_by_defaulton unmodifiedupstream/master.mx --java-home=lookup:default python-jvm && mx --java-home=lookup:default graalpytest test_sys.py— fails (1 != 0).debugfield to0inSysModuleBuiltins.java.test_sys.py— passes.mx --java-home=lookup:default graalpytest test_sys.py test_sysconfig.py test_sys_settrace.py— passes.Before (unmodified
SysModuleBuiltins, new test only)After (debug hardcoded to 0)
Nearby sys tests
This change was prepared with AI assistance. I remain responsible for the contribution and have reviewed it.