Repository navigation
Conversation
ndossche
approved these changes
Oct 17, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Okay, but I think the name of the new field could be better, it actually means "no successful completion since last attempted execution"
11690db cleared stmt->executed on entry to execute() so a failed execute() could not leave the previous result fetchable. Drivers read that flag as "executed successfully at least once": pdo_oci reallocates its column buffers when it is clear, while PDO core skips describing the columns again because they are still set, so the OCI defines keep writing into the freed buffers; pdo_ibm leaks its column descriptors. Record the failed execute() in a separate bit instead. The cursor closer still runs on entry, but drivers without one are no longer drained, which also made them fetch every remaining row on each re-execute. Fixes phpGH-24372
iliaal
force-pushed
the
fix/gh-24372-pdo-executed-flag
branch
from
October 18, 2026 13:56
892d5b2 to
c68042e
Compare
Member
Author
|
Renamed to |
Member
|
Sounds good, thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
11690db clears
stmt->executedon re-execute. pdo_oci reads that as a first execution and reallocates its column buffers while PDO core keeps the old descriptions, so the second fetch crashes; pdo_ibm leaks instead. A failed execute() is now tracked in a separate bit andexecutedis left alone. closeCursor() followed by execute() crashes pdo_oci the same way on every version; that needs a pdo_oci fix (php/pecl-database-pdo_oci#46).This is a much more simplified approach, personally I think this is much cleaner than the original
Fixes #24372