Skip to content

GH-23423: Return correct return value when write fails - #24382

Open
Sjord wants to merge 1 commit into
php:masterfrom
Sjord:fix-gh-23423
Open

Sjord wants to merge 1 commit into
php:masterfrom
Sjord:fix-gh-23423

Conversation

@Sjord

@Sjord Sjord commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

php_handle_aborted_connection did not always abort, i.e. if ignore_user_abort=1. So if sending fails and ret is 0, then remaining is never decremented and this loops forever.

Fix #23423

php_handle_aborted_connection did not always abort, i.e. if
ignore_user_abort=1. So if sending fails and ret is 0, then remaining is
never decremented and this loops forever.

Fix php#23423
@Sjord
Sjord marked this pull request as ready for review October 18, 2026 16:31
@Sjord
Sjord requested a review from TimWolla as a code owner October 18, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php_embed_ub_write does not return on error

1 participant