Skip to content

ext/standard: skip proc_open descriptor 0 tests on Solaris. - #24410

Closed
devnexen wants to merge 4 commits into
php:PHP-8.6from
devnexen:proc_open_desc0_solaris_test_fix
Closed

devnexen wants to merge 4 commits into
php:PHP-8.6from
devnexen:proc_open_desc0_solaris_test_fix

Conversation

@devnexen

Copy link
Copy Markdown
Member

The tests check which file descriptor 0 points to by calling readlink() on /proc/self/fd/0. On Solaris/illumos the entries in /proc/self/fd are not symlinks, so readlink() fails with EINVAL and the tests fail.

The tests check which file descriptor 0 points to by calling readlink()
on /proc/self/fd/0. On Solaris/illumos the entries in /proc/self/fd are
not symlinks, so readlink() fails with EINVAL and the tests fail.
RLIM_INFINITY is (rlim_t)-3 there, rejected by the >= -1 range check.
flock() is emulated with per-process fcntl() locks there.
@jorgsowa

Copy link
Copy Markdown
Contributor

If you can check I have tackled those issues:
#24377
#24377

Also the branch for them should be different, accordingly 8.5 and 8.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants