Repository navigation
Conversation
usort(), uasort(), uksort(), array_multisort() and the user-callback array_diff()/array_intersect() variants save and restore a request-global comparator in LIFO order. A comparator that suspends a Fiber lets another fiber's sort overwrite it, so the restore writes back a stale pointer (wrong comparator, or a segfault in array_multisort()). Block fiber switching while the global is live. Suspending from the comparator now throws a FiberError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usort(), uasort(), uksort(), array_multisort() and the user-callback array_diff()/array_intersect() variants save and restore a request-global comparator in LIFO order. A comparator that suspends a Fiber lets another fiber's sort overwrite it, so the restore writes back a stale pointer (wrong comparator, or a segfault in array_multisort()).
Block fiber switching while the global is live. Suspending from the comparator now throws a FiberError.