Repository navigation
Conversation
Reject unsupported ATTR_ORACLE_NULLS values before narrowing them into the two-bit field, preserving the previous mode when validation fails. The constructor and setAttribute() share this validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDO accepted unsupported values for
PDO::ATTR_ORACLE_NULLSand truncated them into its two-bit storage, so 4 silently selected PDO::NULL_NATURAL. Invalid modes now raise ValueError before changing the attribute, including when supplied through constructor options.