Repository navigation
Conversation
Check the normalized timeout against the actual timeval seconds field before conversion. Preserve signed components and the -1 unlimited timeout, including on platforms with 64-bit time_t and 32-bit PHP integers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream_set_timeout()can overflow when seconds and microseconds are combined, or narrow the result on Windows. Validate the normalized value against the platform timeout range before conversion, preserving signed components and the -1 unlimited timeout. This addresses the overflow separately from the timeout policy changes in #16246.