Skip to content

Fix quoted_printable_encode() exceeding the line length for bytes 0xF5 to 0xFF #24442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auraseb wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+21 −1
Open

Fix quoted_printable_encode() exceeding the line length for bytes 0xF5 to 0xFF #24442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/standard/quot_print.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ PHPAPI zend_string *php_quot_print_encode(const unsigned char *str, size_t lengt
lp = 0;
} else {
if (iscntrl (c) || (c == 0x7f) || (c & 0x80) || (c == '=') || ((c == ' ') && (*str == '\015'))) {
if ((((lp+= 3) > PHP_QPRINT_MAXL) && (c <= 0x7f))
if ((((lp+= 3) > PHP_QPRINT_MAXL) && ((c <= 0x7f) || (c > 0xf4)))
|| ((c > 0x7f) && (c <= 0xdf) && ((lp + 3) > PHP_QPRINT_MAXL))
|| ((c > 0xdf) && (c <= 0xef) && ((lp + 6) > PHP_QPRINT_MAXL))
|| ((c > 0xef) && (c <= 0xf4) && ((lp + 9) > PHP_QPRINT_MAXL))) {
Expand Down
20 changes: 20 additions & 0 deletions ext/standard/tests/strings/quoted_printable_encode_line_length.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
quoted_printable_encode() keeps lines within 76 characters for bytes 0xF5 to 0xFF
--FILE--
<?php

foreach (["\xF5", "\xF8", "\xFF"] as $byte) {
$str = str_repeat($byte, 30);
$encoded = quoted_printable_encode($str);
echo bin2hex($byte), ": ", implode(",", array_map('strlen', explode("\r\n", $encoded))), "\n";
var_dump(quoted_printable_decode($encoded) === $str);
}

?>
--EXPECT--
f5: 76,15
bool(true)
f8: 76,15
bool(true)
ff: 76,15
bool(true)
Loading