Repository navigation
Reuse parsed traceback source ASTs within a session - #15210
Closed
DeviousCardi wants to merge 2 commits into
Closed
DeviousCardi wants to merge 2 commits into
DeviousCardi wants to merge 2 commits into
Conversation
Share a bounded source-validated cache between exception reports to avoid repeatedly parsing large modules with many failures. Restore the previous context during config cleanup so nested and failed sessions do not leak their active cache. Co-authored-by: OpenAI Codex <noreply@openai.com>
pyba-chronographer
Bot
added
the
bot:chronographer:provided
Author
|
Added the missing no-session/no-caller-cache path to the existing traceback test in 88586f6. It now checks that an uncached lookup returns the same source as a lookup with a caller-owned cache. All 255 focused tests pass (11 skips), and file pre-commit checks, including mypy, pass. Local branch coverage now exercises that path; Codecov will confirm the combined patch result on CI. |
Member
|
unattended agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated failures in a large module reparse the same source for each traceback. This reuses parsed ASTs within a session, with a bounded cache that invalidates changed source and is cleared during cleanup.
Closes #13360. Regression tests cover source changes, nested runs and cleanup. All 4,705 tests passed; local failure-heavy benchmarks improved 2.7–5.1×.
Written by Codex.