Repository navigation
fixtures: announce fixture setup before execution (#13169) - #15214
Open
SaridakisStamatisChristos wants to merge 6 commits into
Open
SaridakisStamatisChristos wants to merge 6 commits into
SaridakisStamatisChristos wants to merge 6 commits into
Conversation
AI-assisted draft prepared with ChatGPT; human review required before upstream PR.
pyba-chronographer
Bot
added
the
bot:chronographer:provided
|
|
||
| tw.flush() | ||
| # End the early marker before any output from the fixture body. | ||
| if msg == "SETUP START": |
Member
There was a problem hiding this comment.
the line or flush decision ideally doesn't encode via a magic constant -
There was a problem hiding this comment.
Thanks for the feedback! I've refactored the line/flush decision to use an explicit "end_line" parameter instead of checking the message string.
The updated implementation preserves the existing behavior, and the CI checks are passing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a "SETUP START" diagnostic line before fixture setup code executes when "--setup-show" or "--setup-only" is enabled.
Currently, the existing "SETUP" message appears only after fixture setup finishes, making it difficult to identify which fixture is hanging.
Addresses #13169.
Changes
Verification
30/30 GitHub Actions jobs passed, covering Linux, Windows, macOS, and multiple Python versions.
Successful CI run: https://github.com/SaridakisStamatisChristos/pytest/actions/runs/39175479981
The verification branch used identical contribution files, plus a CI-only workaround for release tags missing from the fork. That workaround is not included in this PR.
Maintainer feedback
The "SETUP START" wording and separate-line presentation are proposed for discussion. I'm happy to adapt the format based on maintainer preferences.
AI assistance
This contribution was developed with ChatGPT assistance. I reviewed and understood the changes, approved the implementation, and take responsibility for the submitted code.