You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
configure checks fail confusingly under --with-address-sanitizer if libasan is missing #75382
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=Nonecreated_at=<Date2017-08-14.08:01:57.293>labels= ['build']
title='configure checks fail confusingly under --with-address-sanitizer if libasan is missing'updated_at=<Date2019-03-19.12:31:17.603>user='https://github.com/pmatos'
On a Fedora 26 system, I run configure as:
$ ../configure --with-assertions --with-lto --with-pydebug --with-address-sanitizer --disable-ipv6
My pyconfig.h contains:
/* #undef HAVE_CLOCK */
/* Define to 1 if you have the `clock_getres' function. */
/* #undef HAVE_CLOCK_GETRES */
/* Define to 1 if you have the `clock_gettime' function. */
/* #undef HAVE_CLOCK_GETTIME */
/* Define to 1 if you have the `clock_settime' function. */
/* #undef HAVE_CLOCK_SETTIME */
/* Define if the C compiler supports computed gotos. */
/* #undef HAVE_COMPUTED_GOTOS */
When this happens, __PyTime_FromTimespec is undefined in pytime.c:747.
../Python/pytime.c:747:9: error: implicit declaration of function ‘_PyTime_FromTimespec’; did
you mean ‘_PyTime_FromTimeval’? [-Werror=implicit-function-declaration]
if (_PyTime_FromTimespec(tp, &ts, raise) < 0)
^~~~~~~~~~~~~~~~~~~~
_PyTime_FromTimeval
cc1: some warnings being treated as errors
make[2]: *** [Makefile:1553: Python/pytime.o] Error 1
changed the title [-]!HAVE_CLOCK_GETTIME causes problems with _PyTime_FromTimespec[/-][+]configure checks fail confusingly under --with-address-sanitizer if libasan is missing[/+]on Aug 14, 2017
Activity
pmatos commentedon Aug 14, 2017
On a Fedora 26 system, I run configure as:
$ ../configure --with-assertions --with-lto --with-pydebug --with-address-sanitizer --disable-ipv6
My pyconfig.h contains:
/* #undef HAVE_CLOCK */
/* Define to 1 if you have the `clock_getres' function. */
/* #undef HAVE_CLOCK_GETRES */
/* Define to 1 if you have the `clock_gettime' function. */
/* #undef HAVE_CLOCK_GETTIME */
/* Define to 1 if you have the `clock_settime' function. */
/* #undef HAVE_CLOCK_SETTIME */
/* Define if the C compiler supports computed gotos. */
/* #undef HAVE_COMPUTED_GOTOS */
When this happens, __PyTime_FromTimespec is undefined in pytime.c:747.
../Python/pytime.c:747:9: error: implicit declaration of function ‘_PyTime_FromTimespec’; did
you mean ‘_PyTime_FromTimeval’? [-Werror=implicit-function-declaration]
if (_PyTime_FromTimespec(tp, &ts, raise) < 0)
^~~~~~~~~~~~~~~~~~~~
_PyTime_FromTimeval
cc1: some warnings being treated as errors
make[2]: *** [Makefile:1553: Python/pytime.o] Error 1
pmatos commentedon Aug 14, 2017
OK, the problem was the missing libasan which made quite a few checks fail.
We should check for libasan before all other checks, when compiling with --with-address-sanitizer.
[-]!HAVE_CLOCK_GETTIME causes problems with _PyTime_FromTimespec[/-][+]configure checks fail confusingly under --with-address-sanitizer if libasan is missing[/+]matrixise commentedon Mar 19, 2019
Hi Paulo,
Could you try with the associated PR (12433)?
Thank you,