Repository navigation
Process overloads as a whole in two-phase type-checking - #22231
Merged
Merged
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandera (https://github.com/pandera-dev/pandera)
- pandera/api/pandas/array.py:38: error: Unused "type: ignore" comment [unused-ignore]
|
Member
Author
|
The new error in the primer is correct, exactly the kind of false negative this PR fixes. |
JukkaL
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22229
This fixes a regression that can (often) cause false negatives in settable properties.
The problem is that we currently may have some part of an overloaded function to be scheduled for processing as part of interface, and other parts to be processed as parts of implementation. This is especially problematic for properties (which are internally stored as overloads). I propose to always keep overloads as a whole. It may be marginally slower in parallel mode, but much simpler to reason about.
cc @JukkaL