Repository navigation
Anchor v1: move tests to solana-kite 0.6.1 - #201
Merged
Merged
Conversation
kite 0.6.1 builds spl-token and spl-associated-token-account with no-entrypoint, so their entrypoint symbols no longer clash with the program under test's when a test binary links both. The three compression examples named both crates only to turn that feature on for kite's copies, and no longer do. Claude-Session: https://claude.ai/code/session_014EotgxjmAGtATDFVnBtjXj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows #198. solana-kite 0.6.1 (solanakite/kite-rust#11) builds
spl-tokenandspl-associated-token-accountwithno-entrypoint. Under 0.6.0 each defined anentrypointsymbol, which clashed withcompression/cnft-vault's when its IDL build linked the test binary (duplicate symbol: entrypoint). #198 worked around that by turning the feature on from the three compression test manifests.Changes
compression/cnft-burn,cnft-vaultandcutilsdrop thespl-tokenandspl-associated-token-accountdev-dependencies they named only forno-entrypoint, along with the TODO saying to delete them.Testing
cnft-vault's IDL build (cargo test __anchor_private_print_idl --features idl-build), the step that failed in Anchor v1: send every test transaction as a v1 transaction #198's CI, passes on kite 0.6.1 without the workaround. Neitherlibspl_tokennorlibspl_associated_token_accountdefinesentrypoint(checked withnm).cargo testsweep of all 57 Anchor v1 projects was still running when this PR opened. The first 23 passed, includingcnft-burn, and none failed. CI runs all 57.🤖 Generated with Claude Code
https://claude.ai/code/session_014EotgxjmAGtATDFVnBtjXj
Generated by Claude Code