This repository was archived by the owner on Oct 14, 2026. It is now read-only.
Repository navigation
fix: respect as prop before render for components and HTML tags - #114
Closed
rishilifts wants to merge 3 commits into
Closed
rishilifts wants to merge 3 commits into
rishilifts wants to merge 3 commits into
Conversation
Member
|
please use this component instead: https://react-hook-form.com/docs/useformstate/errormessage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88.
The README says
astakes precedence overrender. That works for an element, but a component or HTML tag currently gets skipped whenrenderis also set.Create the supplied component or tag before considering the render callback. The element path and render-only path stay unchanged.
Added two regression cases that check the wrapper and verify the callback is not called. Both fail before the fix. Updated the existing component-plus-render snapshot to include its expected div wrapper.
Validation with the repository's frozen yarn lockfile: