Repository navigation
Invalidate the layer when borderCurve changes on iOS - #59114
Open
tshmieldev wants to merge 1 commit into
Open
tshmieldev wants to merge 1 commit into
tshmieldev wants to merge 1 commit into
Conversation
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On iOS,
RCTViewComponentView updateProps:oldProps:only invalidates the layer whenborderStyles,borderRadiiorborderColorschange. A change toborderCurvealone is parsed intoborderCurvesbut never reacheslayer.cornerCurve, so the old curve stays on screen until some other border prop changes. This addsborderCurvesto that comparison.Changelog:
[IOS] [FIXED] - Apply
borderCurvechanges that are not accompanied by another border prop changeTest Plan:
On the iOS simulator (0.88.0-rc.4 with React Native built from source), a plain
ViewwithborderRadius: 80andbackgroundColor: 'blue', layered over a staticborderCurve: 'circular'box, togglesborderCurvebetweencircularandcontinuouswithsetStateevery 1.5s. Before the change the shape never changes, after it thecontinuousframes show thecircularbox outlining the corners.