Repository navigation
Conversation
Merged
4 of 8 tasks
mfazekas
marked this pull request as ready for review
October 19, 2026 09:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Since #57602, a static pod that declares
spm_dependencyis built into the shared products dir, andrewrite_aggregate_modulemap_referencesrewrites the aggregate-fmodule-map-fileflags from<Pod>/<Pod>.modulemapto<Pod>.modulemap. CocoaPods names the module map after the pod's module, though (${PODS_CONFIGURATION_BUILD_DIR}/<label>/<product_module_name>.modulemap), and the module name differs from the pod name whenever the pod name isn't a C identifier. For@rnmapbox/maps(podrnmapbox-maps, modulernmapbox_maps) the flag keeps pointing atrnmapbox-maps/rnmapbox_maps.modulemap, which no longer exists, and the app fails to build on 0.87, 0.88 and current nightlies:This takes the module name from the aggregate target's pod targets instead of assuming it equals the pod name.
Changelog:
[IOS] [FIXED] - Fix "module map file not found" for
spm_dependencypods whose module name differs from the pod nameTest Plan:
test_module_map_references_use_the_module_name_of_pods_built_into_the_shared_products_dirtoscripts/cocoapods/__tests__/spm-test.rb. It fails before the change (thernmapbox-maps/rnmapbox_maps.modulemapreference is left as is) and passes after;ruby spm-test.rb: 9 tests, 25 assertions, 0 failures.react-native@0.89.0-nightly-20261018-27e77216eand@rnmapbox/mapswith its Swift Package Manager opt-in ($RNMapboxMapsSwiftPackageManager = true). Before:pod installwrites-fmodule-map-file="${PODS_CONFIGURATION_BUILD_DIR}/rnmapbox-maps/rnmapbox_maps.modulemap"intoPods-App.debug.xcconfigand the build fails with the error above. After applying this patch to the app'snode_modules/react-native: the flag is${PODS_CONFIGURATION_BUILD_DIR}/rnmapbox_maps.modulemapand the Debug build succeeds. With the equivalent path rewrite applied on the library side, the app also launches on the simulator and shows the map, and a Release archive succeeds.