Repository navigation
[12.x] Fix integer range patterns at int32 boundaries - #8858
Merged
Merged
Conversation
fhammerschmidt
force-pushed
the
backport/8717-v12
branch
from
October 13, 2026 13:26
a12372f to
e595878
Compare
fhammerschmidt
marked this pull request as ready for review
October 13, 2026 17:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87ad151713
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cknitt
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #8717 (commit
52783c8f72d24a725060054756cd5f5452c27d71) tomaintenance/12.xfor the next v12 patch release. The maintenance branch already contains the related fix from #8714.Use signed int32 bounds for integer match intervals and normalize accepted typed integer constants before pattern analysis. This fixes ranges ending at
2147483647and wrapped aliases such as-0xFFFF_FFFF/1. Wrapped aliases can now produce unused-case warnings, as described in the 12.3.2 changelog.Adapt the matching calls to v12's existing location and switch-name arguments. Port the two unit regressions into a registered integer-constant test module using v12's Lambda conversion, retain the runtime and diagnostic regressions, and regenerate the JavaScript snapshot with the v12 compiler.
Validation:
node scripts/test.js -ounit -mocha -bsb -docstrings: 195 unit tests, 921 runtime tests, all 40 build fixtures, stdlib and CommonJS checks, and 754 documentation examples pass.dune build @fmtwith OCamlFormat 0.27.0, ReScript formatting checks for the changed fixtures, and repository Biome 1.9.4 checks pass.CHANGELOG.mdentries for 12.3.2 and whitespace validation.