Repository navigation
Conversation
A Content-Type with a trailing semicolon such as "text/html; charset=utf-8; " made type_params raise NoMethodError, which also broke reading the body with response_body_encoding = true.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Content-Type with a trailing semicolon, like
text/html; charset=utf-8;, makestype_paramsraiseNoMethodError(undefined methodstripfor nil), because the last split element is blank. Withresponse_body_encoding = truethis breaks reading the response body.This skips blank parameters. I added tests for
type_paramsand for theresponse_body_encodingpath.Note: #312 touches the same lines, so I am happy to rebase on top of it or close this if the fix gets folded in there.