Repository navigation
Conversation
A 416 Range Not Satisfiable response may carry `Content-Range: bytes */1000` (RFC 9110 Section 14.4). `content_range` only accepted the `first-last/length` form, so it raised `Net::HTTPHeaderSyntaxError` for this valid value. `range_length` did too, and `read_body` calls it when there is no Content-Length, so reading the body of such a response failed. Accept the unsatisfied-range form and return nil, since it has no byte range. The body is then read to EOF as before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 416 response can carry
Content-Range: bytes */1000(RFC 9110, section 14.4). Right nowcontent_rangeandrange_lengthraiseHTTPHeaderSyntaxErrorfor it, soread_bodyfails on 416 responses that have no Content-Length.This returns nil for the
*/lengthform, the same way non-byte units are handled since #63. Tests added.