Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #187.
Multipart requests containing both UTF-8 text and binary data can raise
Encoding::CompatibilityErrorwhile building the body. Append buffered multipart pieces as binary strings, preserving their bytes without transcoding or changing the caller's strings.Changes
Testing
On macOS with Ruby 4.0.6:
bundle exec ruby -Ilib -Itest/lib -rhelper test/net/http/test_http.rb --name /test_set_form/(8 tests)bundle exec rake test(209 tests)bundle exec rake rbs:test(29 tests)bundle exec rake buildThe new regression raises the reported encoding error before the fix. The other Ruby versions and operating systems in CI were not run locally.