Repository navigation
Stop loading resolv from net/http - #355
Merged
Merged
Conversation
Net::HTTP required the whole DNS resolver, which also reads the system DNS configuration at load time, only to match Resolv::IPv4::Regex and Resolv::IPv6::Regex when deciding whether to send SNI. Use the same inlined regexps as the copy vendored in RubyGems, so that the two stay identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require "net/http"loads the wholeresolvlibrary, which also reads the system DNS configuration, only to matchResolv::IPv4::RegexandResolv::IPv6::Regexwhen deciding whether to send SNI. This forward-ports ruby/ruby#19316, which inlines those regexps as private constants. They are byte-identical to the copy vendored in RubyGems, so the two stay in sync.After this, requiring
net/httpno longer definesResolvorSecureRandomas a side effect, so code relying on that needs its ownrequire. It also makes #337 unnecessary, since that approach still loadsresolvon the first HTTPS connection.Generated with Claude Code