Repository navigation
Conversation
winsize can report width 0; treating that as truthy made width_for return -1. Fall back to COLUMNS / 80 when width is zero. Also use class.to_s when class.name is nil so object_group works for anonymous classes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PP.width_fortreated a zerowinsizewidth as usable because0is truthy in Ruby, so it returned-1instead of falling back toCOLUMNS/ 80. Non-tty or constrained devices can report width 0; treat that like a missing width.PP#object_groupalso concatenatedobj.class.name, which isnilfor anonymous classes and raisedTypeError. Useclass.to_swhennameis nil so custompretty_printimplementations can group anonymous class instances.Tests
test_width_for_zero_winsize— winsize[24, 0]yields79test_object_group_anonymous_class—object_grouponClass.new.newno longer raisesruby -Ilib:test test/test_pp.rb -n '/width_for_zero|object_group_anonymous|list0123/'→ 4 tests, 0 failures.