Repository navigation
Run tests and benchmarks on Windows in CI - #555
Merged
Merged
Conversation
rmagick builds on Windows only against the layout of the official ImageMagick installer, so it fails to find the headers of MSYS2's ImageMagick. Move gruff and rmagick into a graph group that the Windows test job skips, and skip the graph tests there.
The mock rubies are extensionless shell scripts, which File.executable? rejects on Windows, so --chruby aborted the whole test run there. chruby does not exist on Windows anyway.
File.executable? on Windows only accepts executable file extensions, so it is false for run_benchmarks.rb.
Watson1978
reviewed
Oct 15, 2026
| gem "rake" | ||
| gem "rmagick" | ||
|
|
||
| # Windows CI skips this group because rmagick does not build against MSYS2's ImageMagick. |
There was a problem hiding this comment.
Support for MSYS2’s ImageMagick package was added in rmagick/rmagick#1730, so updating rmagick from 6.1.5 in Gemfile.lock to 6.2.0 or later should let it build on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
windows-latestjobs that runrake testandrun_benchmarks.rbwith the latest stable Ruby and ruby-head. ImageMagick is installed from MSYS2 so that rmagick can build. Both jobs feed intoall-tests.