Repository navigation
ci: silence the runpod-flash sunset warning in e2e tests - #627
Draft
justinwlin wants to merge 1 commit into
Draft
justinwlin wants to merge 1 commit into
justinwlin wants to merge 1 commit into
Conversation
runpod-flash 1.21 emits a FutureWarning on import announcing its deprecation. pytest.ini turns warnings into errors, so the e2e conftest failed to import tests/e2e/e2e_provisioner.py and every e2e run (and the validation job behind it) has failed on main since. Set the documented RUNPOD_FLASH_SILENCE_DEPRECATION opt-out for the e2e step.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e job, and the validation job that depends on it, has failed on every
mainpush and PR since runpod-flash 1.21 shipped.Cause
tests/e2e/e2e_provisioner.pyimportsrunpod_flash, which now emits a sunsetFutureWarningon import.pytest.inisetsfilterwarnings = error, so loading the conftest fails before any test runs.Change
Set runpod-flash's documented
RUNPOD_FLASH_SILENCE_DEPRECATION=1opt-out on the e2e step. Moving the provisioner off runpod-flash is a separate change.Verification
Same install as CI (
runpod-flash,pytest-asyncio,pytest-timeout,pytest-rerunfailures,httpx, editable SDK). Without the variable,pytest tests/e2e --collect-only -o addopts=fails with theFutureWarning. With it, 2 tests are collected.