Repository navigation
ndarray-rand: update to rand 0.10 and rand_distr 0.6 - #1607
Merged
Merged
Conversation
Contributor
Author
|
Hi @akern40, gentle ping on this one. This PR is not a heavy change, just a dependency version bump. CI hasn't run yet since it needs workflow approval for first-time contributors. Happy to make any changes needed. Thanks! |
Collaborator
|
@akern40 I was about to merge this, but the cicd seems to be stuck at "conclusion". |
Collaborator
|
Hey sorry everyone, life had gotten a little busy over the past few months but I am trying to dedicate more time here again! I am going through and rebasing PRs to trigger CI, please stand by and I will get this merged |
No changes needed in ndarray-rand itself. Changes in `crates/numeric-tests/tests/accuracy.rs`: - Import `RngExt` for `random_range`. - Replace the removed `SmallRng::from_os_rng` with `SmallRng::from_rng(&mut rand::rng())`. bump ndarray-rand to 0.17.0
akern40
force-pushed
the
update-rand-0.10
branch
from
October 19, 2026 01:19
036b484 to
43dd351
Compare
Collaborator
|
Thank you for your contributions and your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1590
Summary
Bumps
rand0.9 -> 0.10 andrand_distr0.5 -> 0.6 across the workspace. Therand_isaacdev-dependency inndarray-randmoves to 0.5 to matchrand_core0.10.ndarray-rand version bump (need to publish)
ndarray-randgoes0.16.0->0.17.0. Even though its own code is unchanged, updates inrandandrand_distrare breaking changes and these 2 crates are publicly re-exported inndarray-rand.Tests (using crate MSRV 1.87.0)
cargo test -p ndarray-rand: 7 + 4 passcargo test -p ndarray-rand --features quickcheck: 8 + 4 passMSRV
No Change