Repository navigation
feat: add Dimension::from_slice - #1608
Merged
Merged
Conversation
Add a public `from_slice` that returns `None` when the slice length does not match the type's dimensionality (`IxDyn` accepts any length). Now `from_dimension` uses `from_slice`
akern40
force-pushed
the
dimension-from-slice
branch
from
October 19, 2026 01:18
814fbe5 to
9ea47a6
Compare
Collaborator
|
Thank you for the contribution and your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1330
Summary
Add
Dimension::from_slice(&[Ix]) -> Option<Self>, which returnsNonewhenSelf::NDIM.is_some_and(|n| n != ix.len())(the fixed-size types require an exact length match and IxDyn accepts any length)from_dimensionnow usesSelf::from_slice(d.slice())Tests
Added
from_slicetotests/dimension.rs.cargo testpasses.