Repository navigation
fix(ci): address new lints and float constant deprecations - #1619
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is failing on
master, and so on every open PR, because of new warnings in recent Rust and Clippy: thestd::f64::NAN-style module constants are deprecated,clippy::from_iter_instead_of_collectwas removed (so ourallowfor it tripsrenamed_and_removed_lints), andclippy::question_marknow flags threematchblocks in the indexed iterators.Link to Devin session: https://app.devin.ai/sessions/84f0ca00a1484da1b6fbe842f7104a73
Open in Devin Desktop: https://app.devin.ai/desktop/session/84f0ca00a1484da1b6fbe842f7104a73?variant=devin
Requested by: @akern40