Skip to content

fix: export Ranked from the prelude - #1621

Merged
akern40 merged 2 commits into
refactorfrom
ranked-prelude
Oct 19, 2026
Merged

akern40 merged 2 commits into
refactorfrom
ranked-prelude

Conversation

@akern40

@akern40 akern40 commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

#1575 moved ndim off of Dimension and onto the new Ranked supertrait. Generic code with a D: Dimension bound still works, but calling .ndim() on a concrete dimension type now needs Ranked in scope, so this stopped compiling:

use ndarray::prelude::*;
Ix2(3, 4).ndim(); // E0599: trait `Ranked` is not in scope

This exports Ranked from the prelude next to Dimension. Code that imports ndarray::Dimension directly, rather than going through the prelude, still has to import ndarray::layout::ranked::Ranked too.

CI is red until #1622 lands. That PR fixes lints from newer toolchains that also fail on refactor itself.

Link to Devin session: https://app.devin.ai/sessions/4b52e943e29a466ea652d856b7f556c4
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b52e943e29a466ea652d856b7f556c4?variant=devin
Requested by: @akern40

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@akern40
akern40 merged commit 0745418 into refactor Oct 19, 2026
7 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant