Repository navigation
Conversation
b69fa58 to
db73793
Compare
|
Thanks for this. We tried it (branch at
The standalone We'd really like to see this merged and released. Is anything blocking it that we could help with, like testing on more real-world projects? |
|
@jupblb Thanks for yesterdays chat again! I'd like to review this PR and get it merged. I'm going to need to spend some time to build the necessary context, but as we discussed I agree this is the best path forward for indexing Kotlin code. @ofir-blaus If you could test this on some more real world projects, I'd be thrilled. I'm especially curious about Android projects. If you could also compare the output you get on the projects that do build with the old indexer to the indexes you're getting from the new one that would be very helpful. |
|
@christoph-sg thanks for picking this up! Happy to help with testing. We compared the old indexer (scip-java 0.13.1) with this branch on three projects:
We had to use Kotlin 2.2.x, because 0.13.1 only loaded on 2.2.0 and 2.2.10. It failed on 2.1, 2.2.20+, 2.3 and 2.4. On Android it also produced no output until we attached the plugin with an extra Gradle script. Overall: the results mostly match. Where both indexers mark the same code, 94–98% of symbols are identical. The new one finds 6–11% more references and runs 2–3x faster, without a build. Better in the new indexer:
Missing or different in the new indexer:
Same in both:
One crash, new indexer only: a top-level Happy to run it on more projects, or share the scripts, if that helps. |
Replaces the scip-kotlinc compiler plugin with scip-kotlin-analysis, a standalone indexer built on the Kotlin Analysis API. The indexer bundles its own analysis engine, so the Kotlin version of indexed projects is no longer a binary-compatibility constraint.