Repository navigation
Preserve caller parameters and per-client API keys - #46
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing a parameter dictionary across clients currently carries the first client's injected API key into later requests. Keyword overrides also change the caller's dictionary.
Copy parameters before applying overrides in the four public methods and before injecting the default key in HTTPClient.request. Explicit caller-provided keys retain precedence.
Adds 14 offline regression cases covering all four public methods, keyword overrides, direct requests, and explicit keys. Requests are serialized normally and intercepted before network I/O.
Validation: 9 failures and 5 passes before the fix; 76 passes and 41 deselected afterward across the new tests and the six offline test files listed in CONTRIBUTING.md (
-k 'not live').git diff --checkpasses. No live API calls were made.