Repository navigation
fix(copilot): load workflow chat history through the windowed chat routes - #9113
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 18 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge, with no new actionable issues found. SummaryWorkflow Copilot history now uses the windowed chat routes instead of the legacy fallback.
Reviews (2) · Last reviewed commit: "test(copilot): name each workflow chat f..." · Reviewed by Greptile |
Collaborator
Author
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copilotchats, but the chat detail route only servedmothershipchats. Every panel history load got a 404 and fell back to the legacy/api/mothership/chat?chatId=read, whose response has nomode— which the history parser requires — so the panel showed "Failed to load chat history" on every load and refetch, after reading the whole transcriptauthorizeCopilotChatRow) already checks workflow read for workflow chatsrequireOwnedChatReadable, sharingauthorizeChatWorkflowRead/isChatModeAvailablewith the detail read). Other chat use cases are unchanged for every chat that carries a workspaceworkspace_id, never backfilled) is scoped through its workflow while its owner may read that workflow, so these chats load their older pages and stream status instead of being refusedGET(app/api/copilot/chat/queries.ts,getAccessibleCopilotChat, its column set and query schemas); the list branch of that GET had no callers either. Shrunk the explicit-any, source-conventions and unused-exports baselines accordinglyType of Change
Testing
replay-budget.integration.ts; 404 on the current code); older pages and stream status serve a workflow copilot chat including a legacy row without a workspace, and refuse one whose workflow is archived (transcript-pages.integration.ts,read-stream-status.integration.ts; the served cases fail on the current code)apps/simtype-check, biome,check:explicit-any,check:unused-exports,check:test-patterns,check:comment-hygiene,check:boundaries; type-check, full audits and integration suites run in CIChecklist
test-auditauthoring gate)