Repository navigation
improvement(search): rank across sources by query terms only on the Search page - #9138
Closed
waleedlatif1 wants to merge 1 commit into
Closed
waleedlatif1 wants to merge 1 commit into
waleedlatif1 wants to merge 1 commit into
Conversation
…earch page The Search page's result list keeps the cross-source relevance order (#9134). MCP and assistant searches return to fusion order, which interleaves sources: an end-to-end client benchmark found no gain from relevance order there, and the client searched less.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
|
Closing in favor of one bundled PR once the change is proven end to end. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryThis PR limits query-term ranking to the Search page. As explicitly intended by
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/knowledge/search, its only caller) and returns MCP and assistant searches to fusion order, which interleaves sources by their own rankrankByRelevanceinput onsearchLiveKnowledge, set only by that routeWhy
Type of Change
Testing
application.test.ts: the cross-source case now checks both surfaces — relevance order withrankByRelevance, fusion order without; it fails with the gate removed (59 pass)Checklist
test-auditauthoring gate)