Repository navigation
fix(chat): treat browser tab metadata as untrusted and bound attachment resolution - #9161
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
 [Medium impact] The PR appears safe to merge; no actionable new issue was found. SummaryThe PR quotes browser tab metadata as untrusted JSON, drops unsafe URLs, and limits attachment resolution to four items at once.
Reviews (3) · Last reviewed commit: "fix(chat): keep truncated browser tab ti..." · Reviewed by Greptile |
…nt resolution Browser tab attachments put the client-sent page title and URL straight into the turn context as prose. The URL now goes through safeBrowserSelectionUrl (credentials and non-http(s) URLs dropped, title kept), the title is capped, and both are quoted inside an untrusted JSON block. The block format is shared with the browser and terminal selection formatters via formatUntrustedJsonBlock. Open-tab attachments resolved with an unbounded Promise.allSettled fan-out; they now run through mapWithConcurrency at CONTEXT_RESOLUTION_CONCURRENCY with a total mapper, so per-tab failures are still logged and skipped in order. The project file read integration suite now deletes its fixtures' search chunks and builds, which have no cascade from files.
…ded helper Adds mapSettledWithConcurrency next to mapWithConcurrency, as that helper's contract asks, and uses it for open-tab attachments. The Project file read teardown now finds search builds by fixture owner, so builds whose file is already gone are removed too.
40a8170 to
126dc10
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
1 participant
Summary
safeBrowserSelectionUrl, which drops credentialed and non-http(s) URLs. The title (capped) and URL are quoted in anUNTRUSTED BROWSER TABJSON block, the same way browser and terminal selections already are; the URL used to be inlined as plain instruction textformatUntrustedJsonBlockinselection-context.tsreplaces the copies in the browser and terminal selection formatters, with byte-identical output for bothmapWithConcurrencyat the existingCONTEXT_RESOLUTION_CONCURRENCY(now incontext-limits.ts) instead of an unboundedPromise.allSettled; each resolution stays settled-style, so logging and persistence order are unchanged. No schema limit was added, so no request that is valid today gets rejectedproject-file-read.integration.tsteardown deletes the fixture files' search chunks and builds, mirroringowners.integration.tsType of Change
Testing
post.test.tscases: a credentialed URL never reaches context, and the title and URL sit inside the untrusted block. Both fail on the previous browser branchpost.test.ts,process-contents.test.ts,selection-context.test.tspass (169 tests)check:comment-hygiene,check:source-conventions,check:explicit-any,check:test-patterns; full suite and integration in CIChecklist
test-auditauthoring gate)