Add/Edit Bookmark Dialog by F3l1x1vo · Pull Request #278 · stackabletech/cockpit

F3l1x1vo · 2026-07-31T07:26:49Z

This PR adds a bookmark modal for adding and editing bookmarks. Currently, they are saved in localStorage (not a database like we hoped. The database is a v1 feature of the S3 Storage Browser and not yet available on the parent branch). Migrating these bookmarks to the database is an issue for later (#277).

The bookmarks are currently shown in a section on the dashboard but we will change the display of these as well (#271)

Closes #270 #271 #275

stackable-cla · 2026-09-10T12:00:09Z

All committers have signed the CLA.

Bohreromir

Unless I do miss something the whole PinForEveryone does not work as its only stored in LocalStorage. Opa could then be removed too.

I havent yet read the whole thing, but I think this is enough for the meantime.

Feel free to ask for any clarifications.

Bohreromir · 2026-09-14T09:18:36Z

+      pinned,
+      // Only admins can set the "pin for everyone" flag; non-admins keep the
+      // existing value (e.g. when editing a bookmark pinned by an admin).
+      pinnedForEveryone: isAdmin ? pinnedForEveryone : (bookmark?.pinnedForEveryone ?? false)


Okay, I didn't knew that. So the way is forward is: merge this and s3-file-browser, then create a new pr in which its saved to the db?

Do we have an Issue for that?

F3l1x1vo · 2026-09-14T12:13:34Z

@Bohreromir #278 (comment)

I had hoped that the v1 PR (#208) would be merged already when this PR was ready for review. Thus we can either merge both and add a new issue or wait on the other PR to be merged since #275 speaks of a database being used. I would just wait on the other PR since this bookmark feature is not time sensitive.

Bohreromir

nearly done ;)

This reverts commit 740391c.

- add ProductIcon component; logo fallback via component state - per-product badge text colour for WCAG AA contrast, guarded by a unit test - validate stored bookmarks per entry so one bad entry does not wipe all - show name/URL errors on submit and URL blur instead of a silently disabled button - prefill the default product name; refill it after the name is cleared - hide the duplicate dashboard icon link from assistive technology - guard localStorage writes; reuse action_close instead of button_close

github-actions · 2026-10-19T14:19:36Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	64.84%	8688 / 13399
🔵	Statements	63.94%	11689 / 18281
🔵	Functions	66.16%	2783 / 4206
🔵	Branches	55.04%	4989 / 9064

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/lib/client/local-storage.ts	88.23%	80%	100%	100%	9, 25
src/lib/components/dashboard/AddBookmarkModal.svelte	95.23%	81.13%	94.33%	97.01%	113, 180, 179, 247-250, 246, 190, 270
src/lib/components/dashboard/ProductIcon.svelte	100%	100%	100%	100%
src/lib/components/layout/NavigationProgress.svelte	0%	0%	0%	0%	8-38
src/lib/components/layout/sidebar/Sidebar.svelte	0%	0%	0%	0%	115-285
src/lib/components/layout/sidebar/nav-items.ts	0%	0%	0%	0%	14-42
src/lib/components/storage/explorer/FolderRow.svelte	71.6%	54.28%	78.94%	63.82%	35, 42-69
src/lib/components/storage/explorer/ObjectTable.svelte	52%	34.25%	66.66%	42.13%	22-23, 25, 55-58, 75-200, 288-291, 314
src/lib/dashboard/bookmarks.svelte.ts	40%	41.66%	40%	45.45%	34-53
src/lib/dashboard/products.ts	53.33%	100%	41.66%	50%	67-133
src/lib/dashboard/types.ts	100%	100%	100%	100%
src/lib/storage/bookmarks.svelte.ts	73.07%	53.44%	76.19%	84.33%	18, 53, 71, 101, 103, 111, 112, 119, 121, 123, 129, 143, 144, 147, 150-155, 159, 162-167
src/lib/storage/persistence.ts	100%	100%	100%	100%
src/routes/(app)/+page.svelte	34.45%	15.38%	33.33%	35.08%	18-24, 28, 51-52, 50, 58, 15-120

Generated in workflow #1116 for commit 5872e60 by the Vitest Coverage Report Action

…e-label hosts

Every write stores the whole list, so a tab with a stale list overwrote bookmarks saved in another tab. Reload the list on storage events.

Move loadFromStorage/persistToStorage to $lib/client so the dashboard bookmark store reuses them instead of duplicating them.

…titles

Unrelated to bookmarks; deriving the better-auth baseURL from the request host in dev is out of scope here.

…name

…modal

wasOpen no longer needs to be reactive, and the bookmark is read untracked, so the effect depends on open only.

The form is initialised on every open, so resetting it before closing is not needed. The preview guard was always true and getDefaultName() only wrapped selectedProduct.defaultName.

Modal already applies the modal class, and the close button now sets open = false instead of relying on a method="dialog" form.

F3l1x1vo requested a review from dklOrdix July 31, 2026 07:26

F3l1x1vo self-assigned this Jul 31, 2026

F3l1x1vo changed the base branch from feat/iframe-modularization to main July 31, 2026 08:11

F3l1x1vo force-pushed the feat/app-bookmark-dialog branch from c622e28 to fbfa6e6 Compare July 31, 2026 08:17

F3l1x1vo force-pushed the feat/app-bookmark-dialog branch from 286a34a to 7a7d76c Compare September 2, 2026 05:23

F3l1x1vo mentioned this pull request Sep 3, 2026

Feat/iframe modularization #273

Closed

Bohreromir self-requested a review September 11, 2026 07:41

Bohreromir requested changes Sep 11, 2026

View reviewed changes

Bohreromir mentioned this pull request Sep 11, 2026

epic: First Release Cockpit #294

Open

7 of 17 tasks

F3l1x1vo added a commit that referenced this pull request Sep 14, 2026

#278 implement changes suggested in code review

87137fb

F3l1x1vo added a commit that referenced this pull request Sep 14, 2026

#278 refactor comments

4d79ef9

F3l1x1vo added a commit that referenced this pull request Sep 14, 2026

#278 fix unit tests

6e1a6d0

F3l1x1vo added a commit that referenced this pull request Sep 14, 2026

#278 open bookmarks from dashboard as well

f8daddc

Bohreromir requested changes Sep 14, 2026

View reviewed changes

F3l1x1vo added a commit that referenced this pull request Sep 14, 2026

#278 implement changes suggested in code review

16532d4

Bohreromir reviewed Sep 14, 2026

View reviewed changes

Comment thread src/lib/dashboard/types.ts Outdated

Comment thread .env.example Outdated

F3l1x1vo added a commit that referenced this pull request Sep 15, 2026

#278 implement changes suggested in code review

011d9c9

F3l1x1vo added a commit that referenced this pull request Sep 16, 2026

#278 implement changes suggested in code review

c1ccfb0

F3l1x1vo added a commit that referenced this pull request Sep 17, 2026

#278 implement changes suggested in code review

cc43ef3

F3l1x1vo added a commit that referenced this pull request Sep 17, 2026

#278 strengthen e2e tests to be less flaky

b94619d

F3l1x1vo commented Sep 21, 2026

View reviewed changes

Comment thread src/lib/server/opa.ts Outdated

Comment thread e2e/support/start-mock-opa.ts Outdated

Comment thread .env.example Outdated

Comment thread src/lib/dashboard/types.ts Outdated

F3l1x1vo added 7 commits September 21, 2026 10:46

#270 add bookmark dialog

6d69bb4

add edit bookmarks dialog

c8dfa4e

fix cancel editing bookmark

cfb172f

fix darkmode for icons, cursor pointer over boxes

9aeeb44

update product icons to use colored versions where possible

6800f1d

scaled icons down to 64x64

aa214f0

Revert "scaled icons down to 64x64"

a03f818

This reverts commit 740391c.

Bohreromir force-pushed the feat/app-bookmark-dialog branch from c46ebae to f4802ba Compare October 19, 2026 14:18

Bohreromir added 27 commits October 19, 2026 16:31

fix(bookmarks): accept internal URLs such as IPs, NodePorts and singl…

4546a73

…e-label hosts

fix(i18n): align German dashboard heading with English

44c74ae

fix(a11y): label bookmark dialogs by their headings

61cfdf9

fix(dashboard): truncate long bookmark names and hostnames

47ffb89

fix(sidebar): remove leftover hover-button classes from bookmark items

010e98e

fix(a11y): avoid announcing the sidebar brand twice

9d6d576

fix(bookmarks): keep unsaved edits when cancelling deletion

bf5e7ea

fix(dashboard): show the bookmark environment once

06663db

Merge branch 'fix/flaky-storage-paste-e2e' into feat/app-bookmark-dialog

5d218e5

Merge branch 'main' into feat/app-bookmark-dialog

1d2754b

fix(bookmarks): sync bookmark store across tabs

928d614

Every write stores the whole list, so a tab with a stale list overwrote bookmarks saved in another tab. Reload the list on storage events.

refactor(storage): share localStorage helpers with the bookmark store

10d75a6

Move loadFromStorage/persistToStorage to $lib/client so the dashboard bookmark store reuses them instead of duplicating them.

refactor(dashboard): use material-symbols icons instead of inline SVGs

0090496

refactor(i18n): use feature-prefixed bookmark keys and sentence case …

e383708

…titles

fix(bookmarks): submit the bookmark dialog with Enter

6ae782f

chore: drop dev auth baseURL change from bookmark PR

950aef1

Unrelated to bookmarks; deriving the better-auth baseURL from the request host in dev is out of scope here.

fix(bookmarks): localise product default names and custom link label

6af89f1

fix(sidebar): use the visible label as the Tools toggle's accessible …

248a6cd

…name

fix(bookmarks): name card buttons after their bookmark

ed5fc97

fix(bookmarks): localise the URL placeholder and use an example host

3df1ff6

refactor(bookmarks): share one hostname helper between dashboard and …

3142124

…modal

chore: remove orphaned static Stackable logo

8cf078e

fix: only re-initialise the bookmark form when the dialog opens

62e628e

wasOpen no longer needs to be reactive, and the bookmark is read untracked, so the effect depends on open only.

refactor: drop redundant form resets and dead code in the bookmark modal

04a62f4

The form is initialised on every open, so resetting it before closing is not needed. The preview guard was always true and getDefaultName() only wrapped selectedProduct.defaultName.

refactor: close the bookmark modal like the other modals

d9f7f6b

Modal already applies the modal class, and the close button now sets open = false instead of relying on a method="dialog" form.

Merge branch 'main' into feat/app-bookmark-dialog

29254b7

Merge branch 'main' into feat/app-bookmark-dialog

5872e60

Conversation

F3l1x1vo commented Jul 31, 2026 • edited by Bohreromir Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stackable-cla Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bohreromir Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

F3l1x1vo commented Sep 14, 2026

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

F3l1x1vo commented Jul 31, 2026 •

edited by Bohreromir

Loading

stackable-cla Bot commented Sep 10, 2026 •

edited

Loading

github-actions Bot commented Oct 19, 2026 •

edited

Loading