Repository navigation
feat(patchable)!: Use consistent long index in patches - #1705
Merged
Merged
Conversation
Otherwise git chooses a reasonable length based on how many objects are checked out, to try to avoid ambiguity. But that means some people will export a product version and a change will appear for existing patches they didn't touch.
Techassi
previously approved these changes
Oct 16, 2026
Note: - One patch had the Subject fixed so that the exported filename doesn't change. - Other patches have the Form line show a different hash. Previously they were stale (eg: earlier patch removed after export, or perhaps a reordering of the patch files). - Other differences are due to the diff algorithm when the export happened on my machine. Will look at fixing that here.
…for consistency My local config uses histogram, so the previous commit showed changes in the patches. This reverts those changes.
NickLarsenNZ
commented
Oct 16, 2026
NickLarsenNZ
commented
Oct 16, 2026
NickLarsenNZ
marked this pull request as ready for review
October 16, 2026 14:06
NickLarsenNZ
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
This comment was marked as resolved.
This comment was marked as resolved.
Techassi
approved these changes
Oct 16, 2026
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
previously approved these changes
Oct 19, 2026
Techassi
approved these changes
Oct 19, 2026
NickLarsenNZ
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise git chooses a reasonable length based on how many objects are checked out, to try to avoid ambiguity.
But that means some people will export a product version and a change will appear for existing patches they didn't touch. Eg: #1686 (review)
This change sets a consistent long hash format for the patch index lines.
It also hard-codes the diff algorithm to
myers, which is the git default. I use histogram, so it changed how some patches were presented.versions re-exported
airflow
druid
hadoop
hbase
hive
kafka
nifi
omid
opensearch
opensearch-dashboards
shared
spark-k8s
superset
trino
superset
trino
zookeeper